ani1609 / Spendwise

Spendwise - Your User-Friendly Expense Tracker
https://spendwise-seven.vercel.app/
MIT License
27 stars 50 forks source link

factorize: TransactionForm css #339

Closed SharmaDhruv2511 closed 6 months ago

SharmaDhruv2511 commented 6 months ago

Pull Request

Related Issues: [List any related issues or reference them using the syntax #issue_number.]

Fixes #(issue number)

299

Description: [Provide a brief description of your changes.] As per the requirement I have successfully create a new file Transactionform css and add all the css code which is connected to Transactionform.js component. Checklist:

Screenshots: [If applicable, include screenshots to help reviewers understand your changes.]

vercel[bot] commented 6 months ago

Someone is attempting to deploy a commit to a Personal Account owned by @ani1609 on Vercel.

@ani1609 first needs to authorize it.

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spendwise ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2024 6:42pm
ani1609 commented 6 months ago

@SharmaDhruv2511 you basically need to move all the css properties related to the html elements present inside Transaction.js file to the newly created Transaction.css file. You have copied them, but actually you need to move them cause there is no sense of writing same css properties multiple times.

SharmaDhruv2511 commented 6 months ago

image

css that is written under the return statement, I have to move that css to Transactionform.css, right? @ani1609

ani1609 commented 6 months ago

@SharmaDhruv2511 Please try to understand, you just need to move the css properties for the elements present in TransactionForm.js from ExpenseTracer.css to the newly created TransactionForm.css file.

ani1609 commented 6 months ago

@SharmaDhruv2511 currently, your PR seems like you have coped the code from ExpenseTracker.css to TransactionForm.css but after that you need to delete those from ExpenseTracker.css from that no longer be needed.

SharmaDhruv2511 commented 6 months ago

Please review it @ani1609

ani1609 commented 6 months ago

@SharmaDhruv2511 good work