search

anicolao / npa

Neptune's Pride Agent
GNU General Public License v3.0
8 stars 6 forks source link

Time format (% times) defaults to non-standard format on firefox #2

Closed Skilly146 closed 1 year ago

Skilly146 commented 1 year ago

Platform: Firefox Game Type: 2 player Turn Based

Whenever the page is refreshed or first opened it uses the absolute time format, giving the time that the cycle ends or carriers land (Ex: 3:17pm) which isn't very useful in a turn based game. I'm not sure if real time games default to absolute time as well but if they do I think turn based and real time games should default to the standard time since its the most common

anicolao commented 1 year ago

I would like to persist the user's last chosen time view to the new key/value store and have their game come up the way they left it.

It seems reasonable to me to change the default at the same time, to look at what game type it is and pick the best default. For turn based players, what would the best default be?

anicolao commented 1 year ago

[And yes, right now the real time games also default to absolute times because I really want absolute times in the HUD, but they could all be made relative times if we think that's the best default. Since I plan to persist the setting, I'll have what I want when I play anyway ... one possible advantage of having the default be unusual is that it will 'force' each user to choose the default they want, but I'd rather have good defaults.]

Skilly146 commented 1 year ago

I assumed you were just waiting on persistence to save default settings. I also thought about it as a way to force the user to pick their settings but the problem is a lot of users still don't know the hotkeys so best case it would force them to look up the issue and worse case they assume there is no way to change it and stop using the extension. I think the best default for both real time and turn based games would the the original format because if the user doesn't know how to change formats or doesn't care that feature there's no harm

anicolao commented 1 year ago

OK. i don’t love real time for the ship ETAs but I can always change it, and it is perhaps the least surprising…

anicolao commented 1 year ago

Fixed in 666f4790e2c901f46356c6c2111006c4589e59d0

anicolao commented 1 year ago

Verified in v2.0.6 on firefox on macos.