anidl / multi-downloader-nx

Downloader for Crunchyroll, Hidive, AnimeOnegai, and AnimationDigitalNetwork with CLI and GUI
MIT License
265 stars 44 forks source link

[BUG]: FFMPEG Flags not being picked up #579

Open neoof86 opened 7 months ago

neoof86 commented 7 months ago

Program version

4.4.3

Operating System

Windows

Type

CLI

Service

Crunchyroll

Command used

.\aniDL.exe --service crunchy --but --downloadArchive --dlsubs "en" --dubLang "eng", "jpn" --mp4 --syncTiming true -defaultAudio "eng" --defaultSub "eng" --fileName '${showTitle}\S${season}[${service}] ${showTitle} - S${season}E${episode} [${height}p]' --force c --mkvmergeOptions '-y' --ffmpegOptions "'-y'"

Show ID

GJ0H7QGPK

Episode

2

Console Output

I have an issue which others may have seen but I am trying to pass through the "-y" to FFMPEG so that it will overwrite a file and it does not appear to be doing this an example below

.\aniDL.exe --service crunchy --but --downloadArchive --dlsubs "en" --dubLang "eng", "jpn" --mp4 --syncTiming true -defaultAudio "eng" --defaultSub "eng" --fileName '${showTitle}\S${season}[${service}] ${showTitle} - S${season}E${episode} [${height}p]' --force c --mkvmergeOptions '-y' --ffmpegOptions "'-y'"

This is what I saw in the debug

"ffmpeg" -i "P:\A Sign of Affection\S01[CR] A Sign of Affection - S01E03 [1080p].Japanese.ts" -itsoffset -42ms -i "P:\A Sign of Affection\S01[CR] A Sign of Affection - S01E03 [1080p].English.ts" -i "P:\A Sign of Affection\S01[CR] A Sign of Affection - S01E03 [1080p].01.eng.English.ass" -itsoffset -42ms -i "P:\A Sign of Affection\S01[CR] A Sign of Affection - S01E03 [1080p].01.eng.English.cc.ass" -map 0:a -map 0:v -metadata:s:a:0 language=jpn -metadata:s:v:0 title="undefined" -map 1:a -metadata:s:a:1 language=eng -map 2 -map 3 -c:v copy -c:a copy -c:s mov_text -metadata:s:s:0 title="English" -metadata:s:s:0 language=eng -metadata:s:s:1 title="English cc" -metadata:s:s:1 language=eng '-y' "P:\A Sign of Affection\S01[CR] A Sign of Affection - S01E03 [1080p].mp4"
ffmpeg version 6.1.1-full_build-www.gyan.dev Copyright (c) 2000-2023 the FFmpeg developers
built with gcc 12.2.0 (Rev10, Built by MSYS2 project)
configuration: --enable-gpl --enable-version3 --enable-static --pkg-config=pkgconf --disable-w32threads --disable-autodetect --enable-fontconfig --enable-iconv --enable-gnutls --enable-libxml2 --enable-gmp --enable-bzlib --enable-lzma --enable-libsnappy --enable-zlib --enable-librist --enable-libsrt --enable-libssh --enable-libzmq --enable-avisynth --enable-libbluray --enable-libcaca --enable-sdl2 --enable-libaribb24 --enable-libaribcaption --enable-libdav1d --enable-libdavs2 --enable-libuavs3d --enable-libzvbi --enable-librav1e --enable-libsvtav1 --enable-libwebp --enable-libx264 --enable-libx265 --enable-libxavs2 --enable-libxvid --enable-libaom --enable-libjxl --enable-libopenjpeg --enable-libvpx --enable-mediafoundation --enable-libass --enable-frei0r --enable-libfreetype --enable-libfribidi --enable-libharfbuzz --enable-liblensfun --enable-libvidstab --enable-libvmaf --enable-libzimg --enable-amf --enable-cuda-llvm --enable-cuvid --enable-ffnvcodec --enable-nvdec --enable-nvenc --enable-dxva2 --enable-d3d11va --enable-libvpl --enable-libshaderc --enable-vulkan --enable-libplacebo --enable-opencl --enable-libcdio --enable-libgme --enable-libmodplug --enable-libopenmpt --enable-libopencore-amrwb --enable-libmp3lame --enable-libshine --enable-libtheora --enable-libtwolame --enable-libvo-amrwbenc --enable-libcodec2 --enable-libilbc --enable-libgsm --enable-libopencore-amrnb --enable-libopus --enable-libspeex --enable-libvorbis --enable-ladspa --enable-libbs2b --enable-libflite --enable-libmysofa --enable-librubberband --enable-libsoxr --enable-chromaprint

I also tried just "y" and that threw an error otherwise it just sits there waiting for me to accept the overwrite, the FFMPEG docs seem to just state putting -y as a catch all to overwrite

Additional Information

I have to say @Jaynator495 has been awesome helping me and started using mkvmerge and this was working great until I realized I need to start using the --syncTiming true for a few episodes as in the example there is a difference in lengths causing issues with audio and video

Jaynator495 commented 7 months ago

As far as I'm aware, --syncTiming should work for both ffmpeg and mkvmerge? We actually do have a v2 of that, but it's not quite ready for the mainstream yet.

I will look into what causes the ffmpeg issue, I suspect for whatever reason the commands are not getting passed to the muxer