anidl / multi-downloader-nx

Downloader for Crunchyroll, Hidive, AnimeOnegai, and AnimationDigitalNetwork with CLI and GUI
MIT License
225 stars 38 forks source link

Fixes/enchancements for vtt2ass with new Hidive Q styles #626

Closed IONI0 closed 3 months ago

IONI0 commented 3 months ago

Addresses https://github.com/anidl/multi-downloader-nx/issues/608.


Additional enhancements:

This is done in line 367 if you want to link it up to an option or turn it off.


This is done in line 273, you can change it to Dialogue: 0,${line.start},${line.end},${line.style},,0,0,0,,${line.text});` to make it remain on layer 0.

AnimeDL commented 3 months ago

Could you please fix the eslint errors? I highly recommend setting up your dev environment for eslint if you haven't already

IONI0 commented 3 months ago

I've fixed the Eslint errors a logic error with aligning start time of subs, and added a cli option for combineLines which is false by default. Let me know if anything else is wrong

AnimeDL commented 3 months ago

LGTM, merging