search

anigmetov / hera

Other
4 stars 3 forks source link

Documenting divergence from upsteam PHAT #12

Open gspr opened 1 year ago

gspr commented 1 year ago

Hey. Would it be possible to document the way Hera's embedded PHAT has diverged from upstream?

Or even better: Have you considered upstreaming your changes?

gspr commented 1 year ago

A gentle ping on this matter, @anigmetov :-)

anigmetov commented 1 year ago

Oh, sorry, this issue totally fell off my radar. I ran the diff now, there is one substantial change: I need infinite points, and I need them in case of persistence modules when there are just dimensionless generators. A few years ago I tried to upstream a trivial change that I also need, i.e., marking a function as inline, and the pull request is still there. Therefore I am leaning towards creating my fork of PHAT, pushing the changes there and adding PHAT to the list of dependencies managed by Peru.

mglisse commented 10 months ago

the pull request is still there.

I am not seeing any pull request by you at https://bitbucket.org/phat-code/phat/pull-requests/?state=ALL . Was it before they moved to bitbucket?