anikesh / web-optimizator

Automatically exported from code.google.com/p/web-optimizator
0 stars 0 forks source link

0.6.6-b Move all JavaScript code to </body>: Google AdSense & Amazon ads below the footer #184

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Please before submitting check your problem through Wiki page
http://code.google.com/p/web-optimizator/wiki/Troubleshooter

What steps will reproduce the problem?
1. Active: Move all JavaScript code to </body>
2. Disabled: Ads - Werbung (Kontext und Banner vor </body> verschieben

What is the expected output? What do you see instead?

Javascript driven Google AdSense & Amazon ads are shown below the footer.

What version of the product are you using? On what operating system and
environment?

0.6.6-b 

Please provide any additional information below.

Reproducible: Toggling "Move all JavaScript code to </body>" switches the
effect on & off.

Original issue reported on code.google.com by merzmar...@gmail.com on 16 Nov 2009 at 4:46

GoogleCodeExporter commented 9 years ago
It should be not a bug but a feature (that becomes working)... All scripts now 
are 
moved to </body>. Unobtrusive ads just provide a correct way to do this, raw 
option 
'Move all JavaScript code to </body>' works incorrectly in most of cases.

Can you propose any convinient way to avoid (or just leave) this situation? 
Once more
1) 'Move all JavaScript code to </body>' move now ALL scripts to </body>
2) 'Unobtrusive ads / counters / widgets' move all scripts to </body> safely 
(all 
supported patterns, Google Adwords is supported, Amazon seems do not).

Original comment by sunny.dr...@gmail.com on 16 Nov 2009 at 6:34

GoogleCodeExporter commented 9 years ago
Also can't find any Amazon ads on sankt-georg.info -- can you please provide a 
pattern 
of them

Original comment by sunny.dr...@gmail.com on 16 Nov 2009 at 6:35

GoogleCodeExporter commented 9 years ago
Sorry, it's a new option. 'Move merged JavaScript file to </body>' is a 
different one. 
So I think all is OK here, it seems to work as expected.

Original comment by sunny.dr...@gmail.com on 16 Nov 2009 at 6:39

GoogleCodeExporter commented 9 years ago
Amazon ads became rare lately :)
1 under each article in /artikel.
http://sankt-georg.info/artikel/885/stolpersteine-hamburg-st-georg-broschuere

Yep, I am talking about the new option "Move all JavaScript code to </body>".

In case of the ads shouldn't there be a placeholder and the ad shows up as 
expected?
Same for every Javascript output?

Original comment by merzmar...@gmail.com on 16 Nov 2009 at 7:23

GoogleCodeExporter commented 9 years ago
Amazon Ads pattern addedwith rev.924. Will be in 0.6.7

So I see no other issues here. 'Unobtrusive ads' option creates 'placements' to 
load 
'delayed' JavaScript code there. Disabling 'Unobtrusive ads' leads to no 
placements and 
broken layout.

Original comment by sunny.dr...@gmail.com on 17 Nov 2009 at 12:12

GoogleCodeExporter commented 9 years ago
What is the new option
"Move all JavaScript code to </body>"
good for?

It seems I don't get the user case.

* Unobstrusive works great
* "JavaScript Datei vor </body> einfließen lassen" works great
* "Move all JavaScript code to </body>" destroys the placement of my ads.
* Activated "JavaScript Informer Aufrufe vor </body> verschieben" but don't know
exactly what it does.
* "Counter Aufrufe vor </body> verschieben" is not necessary in my case because 
all
counters are already at the end of the page.
* I don't use "Werbung (Kontext und Banner vor </body> verschieben" because I 
don't
want ads to delay. I'd prefer ads to pop up earlier :)

Original comment by merzmar...@gmail.com on 17 Nov 2009 at 4:05

GoogleCodeExporter commented 9 years ago
fYI - the reasoning for moving JavaScript to the footer is here:
http://developer.yahoo.com/performance/rules.html#js_bottom

Original comment by CADbl...@gmail.com on 30 Nov 2009 at 3:58