search

anikethsaha / mern

:tada: This is boilerplate for MERN stack with integrations like Redux and SSR :tada:
https://mern.netlify.com
MIT License
99 stars 44 forks source link

Fix reducer store logic and add missing dependencies in package.json #102

Closed ypahalajani closed 5 years ago

ypahalajani commented 5 years ago

This PR addresses #23

anikethsaha commented 5 years ago

Awesome Work Man ! Can you please remove the public/js folder. we wont need to carry that workload.

anikethsaha commented 5 years ago

Give me some time to review this ! 😃

ypahalajani commented 5 years ago

Can you please remove the public/js folder. we wont need to carry that workload.

Shouldn't we remove the complete public/ folder and add it to the .gitignore ?

ypahalajani commented 5 years ago

Awesome Work Man !

🤘

anikethsaha commented 5 years ago

Shouldn't we remove the complete public/ folder and add it to the .gitignore ?

Ok either way works fine 👍

ypahalajani commented 5 years ago

Ok either way works fine 👍

Also, since the webpack chunks out the (bundle) bin/server.js as well (along with the other files in the public/ folder), do we remove that as well and add to the .gitignore?

anikethsaha commented 5 years ago

Also, since the webpack chunks out the (bundle) bin/server.js as well (along with the other files in the public/ folder), do we remove that as well and add to the .gitignore?

Remove them ! https://github.com/anikethsaha/MERN-Boilerplate/pull/102#discussion_r331742176

ypahalajani commented 5 years ago

Also, why did this PR drop the code coverage by 0.3% here? I am not able to figure out correctly 🤔

anikethsaha commented 5 years ago

Also, why did this PR drop the code coverage by 0.3% here? I am not able to figure out correctly

Leave it, I guess it may be because of modern js codes...not supportable.

anikethsaha commented 5 years ago

Done remove the public/html. Sorry I forgot to mention that.... That is the entry for frontend. You add only public/js to .gitignore

anikethsaha commented 5 years ago

@all-contributors please add @ypahalajani for infrastructure, code, doc and bug

allcontributors[bot] commented 5 years ago

@anikethsaha

I've put up a pull request to add @ypahalajani! :tada: