Open anikethsaha opened 5 years ago
Hello @anikethsaha
I want to help for CSS IN JS Task
Is it still available?
Awesome. Yeah it's still available. Which library you are going to add?
I want to add Styled Component @anikethsaha
Actually this is my first open source contribution. Can u guide me here?
That's great.
You can fork this project, clone it to your pc and run npm install
Then create a new branch using git checkout -b [your-branch-name]
You can add any name to your branch. Like feat/styled-component
Now you have your project setup. Now install the required libraries like styled-component
And make ur changes
Just try to add styles for the hello.jsx
component.
Ping me on Twitter if you have any doubts : https://twitter.com/anik220798
Okay gonna do it now
Hi @anikethsaha
I have finished it, that means i can make a pull request right?
Woo...that was fast ⏩ Yeah you can raise a Pull request now ! Make sure all the tests are running !
you have to push it in your fork from your local machine !
use this command git push origin <your-branch-name>
It will work if you have cloned your fork !
Please let me know if you are facing any problem
Done it @anikethsaha Please check it on #114
Thanks for ur help @anikethsaha
Feel free to chat me if you need some help
Yeah sure ! 😃
Hey ! @wincentrtz Actually I wanted to add those styling or any extra stuff as a pluggable thing like the user can get options or choose from any of these What do you think about how can we achieve that by keeping minimum work!
I thought of making different branches for each task
If you create a lot of branches, it's going to be hard to maintain it. For example, you are making some of the style branches. Then you are using graphql or axios or some 3rd party again and create their own branches. It's going to be difficult for the developer to combine every single dependency that has been separated into its own branch.
I think we can create a lot of custom hooks and for example, you can see this: https://github.com/styled-components/styled-components/issues/2342 By using it we can give a lot of tools for developer that has been using this code to choose what they want because we have prepared it.
It will make our code cleaner and it can be scaled too.
Yeah, branches are not a good option.
I am working on creating a config file for the project.
keep an eye on v1
branch. Will push some new changes soon
is the issue open? I would like to help
Yeah it's open but need a little tweak to make it configurable with the v1.
Please dm me on https://twitter.com/anik220798 and I will tell you how to make it supportable with mern.json
@manas2297 I guess you can work on any of the remaining options. From here https://github.com/anikethsaha/mern/issues/107#issue-502975601
@anikethsaha tell me how to configure it locally
@manas2297, after cloning it, simply run npm install
and that's it. You can work on a separate branch to keep the master safe
Also, for this particular issue, please try to avoid touching the core part, like if you want to add any library for css-in-js, simply add it in the src/client/components/hello
.
To make it configurable, what I will do is, After you implemented everything, I need to do some copy-paste stuff and writing a script in scripts
folder. I will put a PR in your fork with these changes.
Please dm me on twitter or anywhere you want, I will you in detail how things gonna take place.
Hi was this pull request closed? Is this still available?
Hi! Can I work on this issue?
Hello I want to contribute.
As this project is on a way towards becoming more flexible and customizable. Its pretty good to give the user an option to use any of the modern + classical styling options Planning to have styling options using the following libraries
Postcss
Postcss-css-module
orcss-loader
) by @wincentrtzCSS IN JS
Emotion
Styled-Component
by @wincentrtzaphrodite
linaria
Can add all or any or none 😁