fix: add webpack files to webpack folder (fixes #133)

anikethsaha / mern

:tada: This is boilerplate for MERN stack with integrations like Redux and SSR :tada:

https://mern.netlify.com

MIT License

98 stars 44 forks source link

Closed Ckbhatia closed 3 years ago

Ckbhatia commented 4 years ago

fixes #133

Ckbhatia commented 4 years ago

@anikethsaha Please review the changes, Inform me if there is need for any changes

Ckbhatia commented 4 years ago

What is the benefit of that?

anikethsaha commented 4 years ago

No benifits in particular, but it states that it contains configurations for the project.

like .github folder

Ckbhatia commented 4 years ago

Changes have been made

anikethsaha commented 4 years ago

netlify deployement is failing. Can you check that locally if there is any issue with running the scripts.

Ckbhatia commented 4 years ago

No, I have verified the changes before pushing. 👍

anikethsaha commented 4 years ago

No, I have verified the changes before pushing. 👍

umm, I will check this soon 👍

Ckbhatia commented 4 years ago

Hey, Did you check?

anikethsaha commented 4 years ago

I will check this soon. A bit busy for few coming days

Ckbhatia commented 4 years ago

Bro, it's been 8 days. Can you please review now?

Ckbhatia commented 4 years ago

@anikethsaha Can you check now?

anikethsaha commented 4 years ago

I will check this weekend.

Thank you for your patience

Ckbhatia commented 4 years ago

Bro, I think, contributed to a dead project.

anikethsaha commented 4 years ago

apologies for delay.

Did you test locally is there any issue in that ? I didn't check locally, have some issue with my current OS config.

Ckbhatia commented 4 years ago

I had checked when I fixed this. It was working fine.