search

anilbeesetti / nextplayer

An Android native video player
GNU General Public License v3.0
1.82k stars 80 forks source link

Proper subtitle styling possibility? #464

Open da3dsoul1 opened 1 year ago

da3dsoul1 commented 1 year ago

Amazing player, though lacks some basic functionality of properly displaying subtitles with embedded fonts in them.

Here's an example how subtitle look on both pc and mobile version of vlc/mpv player(sub-pos set to 87): photo_2023-07-23_18-57-09 This is correct displaying meant by the author(font,size,style,etc)

And this is how next player displays them: 2 So as you can see it picks default font and styling for the subtitle, the player has an option to use embedded styles, but looks like it's not 100% compatible. Any way to fully utilize self contained subtitles in an .mkv file? Like it's done in vlc, mpv, mx player.

Also I have a feature request: subtitle position implementation, is it possible to be done in nextplayer?

DarremMolko commented 1 year ago

It's mentioned in the readme (here https://github.com/anilbeesetti/nextplayer#supported-formats). Basically Next Player is based on ExoPlayer which has limited support for SSA/ASS styling.

anilbeesetti commented 1 year ago

Unfortunately, this cannot be fixed easily due to the upstream ExoPlayer lacking proper support for SSA/ASS styling. Upsteam issue link:- https://github.com/google/ExoPlayer/issues/8435

nate-moo commented 9 months ago

@anilbeesetti What would the possibility of implementing libass for SSA/ASS styling support since it seems like that exoplayer issue and PR have stalled or maybe rebasing exoplayer against this PR? google/ExoPlayer#10169 I can take a look at possibly doing it but I am not great at kotlin and android development.