search

anilbeesetti / nextplayer

An Android native video player
GNU General Public License v3.0
1.28k stars 59 forks source link

Feature Request: Ability to add subtitle manually #879

Closed shreyas-a-s closed 3 months ago

shreyas-a-s commented 3 months ago

Currently subtitle needs to be in the same folder and the same name as video file in order to use it in player. It would be nice to have an option (eg: a + icon in the subtitles menu like in the image below) to manually add a subtitle file.

Imagepipe_0.jpg

anilbeesetti commented 3 months ago

Hey @shreyas-a-s, Manual subtitle feature is already there. You just have to long press the subtitle icon. I added a button in the dialog to select subtitles manually instead of long press action just like you suggested to make it more accessible

shreyas-a-s commented 3 months ago

Oh I didn't know that feature existed. But now that I test it, it became obvious that it's there. I am able to add subtitles.

And yeah, that addition of a button would be really great since it improves accessibility and visibility of the feature just like you've said.

Plus thanks for the reply coz otherwise I wouldn't have found that the feature is present.

shreyas-a-s commented 3 months ago

Hey, Anil. Addition of button is currently in the works or have you already pushed to Github? Because I couldn't find the commit.

anilbeesetti commented 3 months ago

Hey @shreyas-a-s, Already merged to main, https://github.com/anilbeesetti/nextplayer/pull/850

shreyas-a-s commented 3 months ago

Ok. Cool. So can I expect it to be included with next release i.e. 0.10.3?

shreyas-a-s commented 3 months ago

Cool. 👍🏼