search

anilbeesetti / nextplayer

An Android native video player
GNU General Public License v3.0
1.69k stars 76 forks source link

[BUG] Unsupported subtitles #880

Closed NikunjKhangwal closed 6 months ago

NikunjKhangwal commented 6 months ago

Describe the bug I'm using YTDLnis (GUI for yt-dlp) to download videos from YouTube and I've noticed this app can't recognize embedded subtitles of those videos. I've tested them with VLC and MX players and they work fine. Overall this app is solid and check most of the boxes for me but this is a major problem I'm facing. I'm linking a example video so you can further investigate and hopefully fix it.

Screenshots IMG_20240321_160855

Device info (please complete the following information):

Additional context Add any other context about the problem here.

moneytoo commented 6 months ago

https://github.com/google/ExoPlayer/issues/11039#issuecomment-1462110423

The codec ID assigned to this track is D_WEBVTT/SUBTITLES and aligns with http://wiki.webmproject.org/webm-metadata/temporal-metadata/webvtt-in-webm (refer to Storing WebVTT data in a WebM Track).

At present, MatroskaExtractor only supports WEBVTT for .mkv files, with a codec ID defined as S_TEXT/WEBVTT. As a result, Exoplayer does not recognize this track since we don't support this codec.

NikunjKhangwal commented 6 months ago

So basically it can't be fixed until Exoplayer implement it? Well that's sad