search

anilbeesetti / nextplayer

An Android native video player
GNU General Public License v3.0
1.28k stars 59 forks source link

Question on permissions #927

Closed IzzySoft closed 2 months ago

IzzySoft commented 2 months ago

My scanner just reported on the latest release:

! repo/dev.anilbeesetti.nextplayer_15.apk declares flag(s): usesCleartextTraffic
! repo/dev.anilbeesetti.nextplayer_15.apk declares sensitive permission(s):
  android.permission.READ_MEDIA_VIDEO android.permission.READ_EXTERNAL_STORAGE

Now those 2 permissions are clear for a video player, so I've added them to your app's "green list":

image

I wouldn't mind to fill the gaps on the remaining permissions if you want to list a short (max ~50 char) explanation for each :wink: (no need for the last one as that's not really a permission but an AndroidX quirk).

I wonder about usesCleartextTraffic, though. I assume that is to also play streams from plain http. Are those still used much?

anilbeesetti commented 2 months ago

Hi @IzzySoft,

INTERNET (needed to play online videos) WRITE_EXTERNAL_STORAGE (needed on lower android version for renaming videos and file operations) usesCleartextTraffic http is still used for home lab stuff (like jellyfin and media servers)

IzzySoft commented 2 months ago

Thanks a lot! Added (and live already). Thought exactly about JellyFin & Co there but wasn't sure :smiley: