Refactor - Githubissues

anilhelvaci / dapp-pool-lending-protocol

The core of the Agoric economy

9 stars 1 forks source link

Refactor #14

Closed anilhelvaci closed 2 years ago

anilhelvaci commented 2 years ago

Remove unused code
Fix vault terminology

anilhelvaci commented 2 years ago

Notes to check before the review

Search for ways to see if using the prioritizedVaults.js from vaultFactory is possible
Make sure to use makeTracer.js from the vaultFactory
Make sure to use interest-math.js from the vaultFactory
Check for inconsistent types in the types.js files
Remove unused copied files that we are now using from the sdk
Remove unused imports
Add comments
- Especially for the checkLiquidation.js method in the liquidationObserver.js file