anilhelvaci / dapp-pool-lending-protocol

The core of the Agoric economy
9 stars 1 forks source link

Update agoric-sdk #40

Open anilhelvaci opened 2 years ago

anilhelvaci commented 2 years ago
anilhelvaci commented 2 years ago

Note on ParamManager

Methods makeParamManagerSync and makeParamManager are now expecting an argument names publisherKit which requires a storageNode and marshaller object as dependencies. There are sample usages in startVaultFactory, params.js. Since we need to build some paramManagers inside our LendingPool contract, I'm a little fuzzy about how to do that. Currently vaultManager.js expects the dependencies for publisherKit from the privateArgs. I can see how to replicate this approach when working with unit tests but I cannot project how to retrieve storageNode and marshaller objects when I actually deploy the contract.

Update

In the Office Hours on 2022-10-26, I've been told that there's no way for an arbitrary contract to get their hands on the storageNode object during an actual deploy. For demonstration, we've came up with two possible workarounds;

anilhelvaci commented 2 years ago

Work Report

anilhelvaci commented 2 years ago

Work above is done

anilhelvaci commented 1 year ago

Update to community-dev branch upon @dckc 's advice on discord

after some testing, community-dev = master = 65d3f14c8102993168d2568eed5e6acbcba0c48a @anil.helvaci | GMT +3 note update to community-dev branch

dckc commented 1 year ago

Note on ParamManager

... on 2022-10-26, I've been told that there's no way for an arbitrary contract to get their hands on the storageNode object during an actual deploy. For demonstration, we've came up with two possible workarounds;

...

  • Who's going to have access to storageNode is determined on bootstrap statically. If the demonstration is going to be on the local chain we can tweak the bootstrap mechanism to give our LendingPool contract access to the storageNode.

We discussed another approach to this issue last week:

Until we have a lower threshold, for local development, devs have all the BLD in the world, so they can grant chainStorage powers to their contracts using swingset.CoreEval governance.

The Dec 14 office hours notes include a zoom recording of the discussion.