Open anilhelvaci opened 2 years ago
Methods makeParamManagerSync
and makeParamManager
are now expecting an argument names publisherKit
which requires a storageNode
and marshaller
object as dependencies. There are sample usages in startVaultFactory, params.js. Since we need to build some paramManagers inside our LendingPool contract, I'm a little fuzzy about how to do that. Currently vaultManager.js expects the dependencies for publisherKit from the privateArgs
. I can see how to replicate this approach when working with unit tests but I cannot project how to retrieve storageNode
and marshaller
objects when I actually deploy the contract.
In the Office Hours on 2022-10-26, I've been told that there's no way for an arbitrary contract to get their hands on the storageNode
object during an actual deploy. For demonstration, we've came up with two possible workarounds;
ParamManager
instead of the one using a storageNode
. The downside of that users will have to pay for transactions to get state updates.storageNode
is determined on bootstrap statically. If the demonstration is going to be on the local chain we can tweak the bootstrap mechanism to give our LendingPool contract access to the storageNode
.timer.tick()
to timer.advanceTo(bigint=)
in all testsquantize
method of ratio.js uses banker's divide approach instead of directly ceiling up the numerators as a rounding strategy, I should update all the tests where I use quantize
for calculation, e.g borrowingRateWork above is done
Update to community-dev
branch upon @dckc 's advice on discord
after some testing, community-dev = master = 65d3f14c8102993168d2568eed5e6acbcba0c48a @anil.helvaci | GMT +3 note update to community-dev branch
Note on ParamManager
... on 2022-10-26, I've been told that there's no way for an arbitrary contract to get their hands on the
storageNode
object during an actual deploy. For demonstration, we've came up with two possible workarounds;...
- Who's going to have access to
storageNode
is determined on bootstrap statically. If the demonstration is going to be on the local chain we can tweak the bootstrap mechanism to give our LendingPool contract access to thestorageNode
.
We discussed another approach to this issue last week:
Until we have a lower threshold, for local development, devs have all the BLD in the world, so they can grant
chainStorage
powers to their contracts usingswingset.CoreEval
governance.
The Dec 14 office hours notes include a zoom recording of the discussion.
fedf049435d7307311219fbab1b2b342ec6acce8
ava
from version 3 to 4.