anilhelvaci / dapp-pool-lending-protocol

The core of the Agoric economy
9 stars 1 forks source link

Bankers Divide #8

Closed anilhelvaci closed 2 years ago

anilhelvaci commented 2 years ago

In the 0.15 version of the sdk the method quantize uses bankersDivide method instead of ceilDivide which causes some changes in the calculation of the interest rates. Either update lending protocol's calculations to this or implement something to keep using ceilDivide

anilhelvaci commented 2 years ago

In beta branch of agoric-sdk quantize method used ceilDivide but in the master it uses bankersDivide, our protocol is now on beta branch but we implemented bankersDivide for math sheet as well. When we update our protocol to master branch we might need to re-open this issue but for now I'm closing it.