Munki 2 - More in Category link doesn't work if Category contains an ampersand

anilkumar61 / munki

Automatically exported from code.google.com/p/munki

Other

0 stars 0 forks source link

Munki 2 - More in Category link doesn't work if Category contains an ampersand #303

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago


What steps will reproduce the problem?
1. Create a category e.g. <string>Graphics &amp; Design</string>
2. populate some packages with the new category
3. click an application in that category then try to click the "More in..." 
link on the right sidebar

What is the expected output? What do you see instead?
expect to see the contents of that category
instead, link is broken

What version of the Munki tools/InstallOSpkg tools are you using? On what
version of OS X?
MSC 4.0.0.1979
OS X 10.9.2

Please provide any additional information below.

The category with an ampersand works correctly in the category list and 
otherwise displays correctly.

Original issue reported on code.google.com by bart.rea...@gmail.com on 27 Mar 2014 at 12:53

GoogleCodeExporter commented 9 years ago

actually to be more accurate - nothing happens when you click the link

Original comment by bart.rea...@gmail.com on 27 Mar 2014 at 12:55

GoogleCodeExporter commented 9 years ago

This issue was closed by revision 52cfcdddd44b.

Original comment by gregnea...@mac.com on 27 Mar 2014 at 1:45

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

That fixed the category issue but introduced another issue where if a detail 
page has a space (e.g. Google Picasa) it doesn't display.

Pre this patch the detail page would be called detail-Google+Picasa.html. 

Category's that used to have a + that now have a space work fine. (e.g.. 
category-Web+Browsers.html is now category-Web Browsers.html)

Original comment by bart.rea...@gmail.com on 27 Mar 2014 at 1:57

GoogleCodeExporter commented 9 years ago

Try the current revision 
(http://code.google.com/p/munki/source/detail?r=f6a4ae8d9d4e)

I don't have spaces in _any_ item name in my repo, so would not have caught 
this.

Original comment by gregnea...@mac.com on 27 Mar 2014 at 2:17

GoogleCodeExporter commented 9 years ago

most of mine don't. Picasa was imported from autopkg though, not using 
munkiimport (and there are one or two other apps in the same boat).

All seems to be fixed now though from what I can see. Cheers.

Original comment by bart.rea...@gmail.com on 27 Mar 2014 at 2:23