Munki 1/2 - DMG containing Install.app fails to import (Non-AAMEE)

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Create/download a DMG that contains "Install.app"
2. Attempt to munkiimport or makepkginfo 

What is the expected output? What do you see instead?
Munki should import the dmg or makepkginfo, but instead you receive an error.

This disk image appears to contain an Adobe CS5 product install.
Please use Adobe Application Manager, Enterprise Edition (AAMEE) to create an 
installation package for this product.

https://code.google.com/p/munki/source/browse/code/client/munkilib/adobeutils.py
#1052

I will cross post on munki-dev and see if there is an alternative/better way to 
determine a bare-metal CS5 package.

Original issue reported on code.google.com by eriknico...@gmail.com on 3 Sep 2014 at 12:56

[GoogleCodeExporter]

Addressed here: 
https://code.google.com/p/munki/source/detail?r=d94b8cfdf17b8c722861b2857fe16acd
137798f7

Original comment by gregnea...@mac.com on 3 Sep 2014 at 3:45

• Changed state: Fixed

[GoogleCodeExporter]

makepkginfo -p also does not work.

Original comment by eriknico...@gmail.com on 8 Sep 2014 at 9:58

[GoogleCodeExporter]

More details, please.

What steps will reproduce the problem?
1. Create/download a DMG that contains "Install.app"
2. Attempt to munkiimport or makepkginfo 

I did this and it works fine. The resulting pkginfo isn't very _useful_, as it 
contains:

    <key>items_to_copy</key>
    <array>
        <dict>
            <key>destination_path</key>
            <string>/Applications</string>
            <key>source_item</key>
            <string>Install.app</string>
        </dict>
    </array>

I'd be happy to fix issues, but I need clearer directions on how to reproduce 
the thing you see as an issue.

Original comment by gregnea...@mac.com on 8 Sep 2014 at 10:07

[GoogleCodeExporter]

makepkginfo /Users/erikgomez/Desktop/foo.dmg -p 
/Volumes/foo/hiddenfolder/foo.pkg

makepkginfo /Users/erikgomez/Desktop/foo.dmg -p /Volumes/foo/foo.pkg

Both instances do not work if Install.app exists.

Original comment by eriknico...@gmail.com on 8 Sep 2014 at 10:49

[GoogleCodeExporter]

Works fine as long as you provide the right path to the pkg.

makepkginfo /Users/erikgomez/Desktop/foo.dmg -p foo.pkg

makepkginfo /Users/erikgomez/Desktop/foo.dmg -p hiddenfolder/foo.pkg

You do not provide the mounted path, as there is no reliable way to make sure a 
disk image is mounted at the path you might provide. (what if there is already 
something mounted at "/Volumes/foo"?) You provide a _relative_ path.

From `makepkginfo --help`:

  Apple Package Options:
    -p PKGNAME, --pkgname=PKGNAME
                        If the installer item is a disk image containing
                        multiple packages, or the package to be installed is
                        not at the root of the mounted disk image, PKGNAME is
                        a relative path from the root of the mounted disk
                        image to the specific package to be installed.If the
                        installer item is a disk image containing an Adobe CS4
                        Deployment Toolkit installation, PKGNAME is the name
                        of an Adobe CS4 Deployment Toolkit installer package
                        folder at the top level of the mounted dmg.If this
                        flag is missing, the AdobeUber* files should be at the
                        top level of the mounted dmg.

Original comment by gregnea...@mac.com on 8 Sep 2014 at 10:59

[GoogleCodeExporter]

I read this multiple times before posting this and yet still misinterpreted the 
wording.

"PKGNAME is a relative path from the root of the mounted disk image." Even 
though it says relative path, I was getting mentally stuck on the "mounted disk 
image". 

Sorry about this.

Original comment by eriknico...@gmail.com on 8 Sep 2014 at 11:36