search

anilmaurya / fast_jsonparser

Fastest Json parser for Ruby, wrapper for simdjson
MIT License
307 stars 10 forks source link

Fix performance on Ruby 3.0 #22

Closed Watson1978 closed 2 years ago

Watson1978 commented 3 years ago

The Makefile generated by extconf.rb has changed in Ruby 3.0. Therefore, when using Ruby 3.0, the optimization flags are not set properly and it reduced the performance.

This patch will set optimization flags in compiling properly.

CXXFLAGS = $(CCDLFLAGS) -g -O2 -std=c++1z -Wno-register  $(ARCH_FLAG)
CXXFLAGS = $(CCDLFLAGS)  -std=c++1z -Wno-register  $(ARCH_FLAG)

This PR will fix https://github.com/anilmaurya/fast_jsonparser/issues/20 issue.

anilmaurya commented 2 years ago

Thanks @Watson1978 for raising this PR, somehow I missed to notice this PR before.

Will review it sometime soon.

anilmaurya commented 2 years ago

Thank you @Watson1978 once again for sending this PR. 🏅

I released version 0.6.0 with your changes.