Closed casperisfine closed 4 years ago
Thank you for contributing.
batch_size
is great addition 🎖
@casperisfine It crashes because the exception is not caught. Any chance the exception could be caught? (try/catch)
@lemire this PR catch it.
+1
When trying to parse a ruby heap dump, my script crashes with:
load_many
uses a buffer (load_many(const std::string &path, size_t batch_size = DEFAULT_BATCH_SIZE)
) which default to1MB
(10^6B). Any document larger than that makes the parser crash.So I changed
load_many
to accept abatch_size:
parameter. I also had to do a bunch of other changes that I'll explain in comments.