anilmuthineni / foxreplace

Automatically exported from code.google.com/p/foxreplace
0 stars 0 forks source link

FoxReplace causes Firefox 32.0+ to crash when a long list is used #147

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Hi, I don't know if this issue have something to do with FoxReplace or if it is 
a Firefox problem itself (I'm sorry if that's the case), but since Firefox 32 
came, I can't use FoxReplace anymore on most pages (the mid to heavyweight 
ones), because when I use it, Firefox freezes and don't even show a sign that 
it will return responsive (I could wait for hours but it doesn't respond 
again), then I have to force close Firefox and restart. I had to downgrade to 
31 so I could continue using both FoxReplace and Firefox. I've tested a simple 
replacing userscript using my substitution list (adapted to JavaScript syntax) 
to see if this issue is only with FoxReplace, but I've got the same result: no 
response. I've tried to use FoxReplace in Firefox 32.0.2 with all extensions 
disabled except FoxReplace, but no different result.
With this, it's almost sure that the problem is Firefox itself, isn't it?

Original issue reported on code.google.com by brunolop...@gmail.com on 24 Sep 2014 at 5:30

GoogleCodeExporter commented 9 years ago
I didn't know about it but yes, it's a Firefox 32 problem: 
https://bugzilla.mozilla.org/show_bug.cgi?id=1070935

Original comment by marc.r...@gmail.com on 24 Sep 2014 at 9:48

GoogleCodeExporter commented 9 years ago
After being stuck in Firefox 31 for months, I finally found out what was 
causing this hang...  it was a regexp. 

Two of them in the substitution list was using /(.+)*/ which causes an 
overprocessing, that is, "find any string of any number of no or any number". 
Using a /?/ instead fixes it. This happens even on Chrome too (with a replacing 
userscript).

What is weird is that the JavaScript debugger never alerted an error, like 
"invalid quantifier", probably because of the parenthesis.

However, I remember that this hang was already happening before I added this 
regexp. Maybe the real bug was fixed in the most recent versions, but I was 
using this freeze-causing regexp, and I couldn't know if it was fixed or not.

Original comment by brunolop...@gmail.com on 10 Apr 2015 at 8:16