search

aniltrkkn / DasOptimization

Pure Java nonlinear equation solving and unconstrained optimization library
Apache License 2.0
11 stars 3 forks source link

two mistakes #1

Open jiweihuang opened 6 years ago

jiweihuang commented 6 years ago

The Class "NewtonStep" has two mistakes. 1.LinearSolver<DMatrixRMaj, DMatrixRMaj> qrSolver = LinearSolverFactory_DDRM.qr(dummyJacobian.numRows, dummyJacobian.numCols); 2.LinearSolver<DMatrixRMaj, DMatrixRMaj> cDecomposition = LinearSolverFactory_DDRM.chol(dummyJacobian.numRows);

Lack "DMatrixRMaj" generic parameter in raw Class

staffanu commented 6 years ago

LinearSolver only takes one type parameter in version 0.31 of ejml. In 0.34 (the latest version), LinearSolver has been renamed to LinearSolverDense, which still only takes one type parameter.

jiweihuang commented 6 years ago

@staffanu thank you.

jiweihuang commented 6 years ago

What new features can we expect to see in 2.0 and when will it be released?

xiaohuangyu commented 6 years ago

I also found this mistake I solve this by add "import org.ejml.interfaces.linsol.LinearSolverDense;" and change "LinearSolver" to "LinearSolverDense"

xiaohuangyu commented 6 years ago

my version is 0.35