Closed mkovatsc closed 1 year ago
I discovered a number of issues, including inconsistencies in the BRSKI Voucher terminology:
UTF8()
wrapping the "unsigned voucher data in JSON syntax" (we are lacking a proper term for this) because RFC7515 considers the JWS Payload to be octets:
JWS Payload
The sequence of octets to be secured -- a.k.a. the message. The
payload can contain an arbitrary sequence of octets.
[...] an artifact signed, directly or indirectly, by the pledge's manufacturer. This artifact is known as the "voucher".
The voucher artifact is a JSON [[RFC8259](https://www.rfc-editor.org/rfc/rfc8259)] document […]
Voucher: A signed statement from the MASA service
[RFC8366] voucher is by default serialized to JSON […]
This document uses the new CBOR [RFC8949] voucher serialization […]
The voucher artifact is a JSON [RFC8259] document that conforms with a data model described by YANG [RFC7950], is encoded using the rules defined in [RFC8259]
:
JSON [RFC8259] document
?I would propose to establish consistent terminology in RFC8366bis and use it accordingly in the new drafts:
jws-voucher:
constrained-voucher:
I am not sure yet if we should append " Data" for the unsigned bits or insert "Signed" before Voucher in the signed bits or omit it, as the format already tells that.
This update was originally triggered by the the idnits error about references in the abstract and warning about updates, which was found while working on the shepherd write-up.
Some distance to my last review let me see further room for improvement of Section 3, where the format for JWS signed voucher artifacts is defined using references to RFC7515 and JSON examples.
The shepherd write-up template also mentions formal language, which the draft is somewhat lacking. Hence, I saw the need to improve the definitions of the format.
Please check and provide feedback! Please note that there might be issues in the Markdown to RFC pipeline, as I only edited the .mkd without build step.