anima-wg / anima-jws-voucher

A format for RFC8366 vouchers in JOSE-signed-JSON.
0 stars 1 forks source link

Fix idnits and improve Section 3 #9

Closed mkovatsc closed 1 year ago

mkovatsc commented 1 year ago

This update was originally triggered by the the idnits error about references in the abstract and warning about updates, which was found while working on the shepherd write-up.

Some distance to my last review let me see further room for improvement of Section 3, where the format for JWS signed voucher artifacts is defined using references to RFC7515 and JSON examples.

The shepherd write-up template also mentions formal language, which the draft is somewhat lacking. Hence, I saw the need to improve the definitions of the format.

Please check and provide feedback! Please note that there might be issues in the Markdown to RFC pipeline, as I only edited the .mkd without build step.

mkovatsc commented 1 year ago

I discovered a number of issues, including inconsistencies in the BRSKI Voucher terminology:

I would propose to establish consistent terminology in RFC8366bis and use it accordingly in the new drafts:

jws-voucher:

constrained-voucher:

I am not sure yet if we should append " Data" for the unsigned bits or insert "Signed" before Voucher in the signed bits or omit it, as the format already tells that.