anima-wg / constrained-join-proxy

1 stars 2 forks source link

Objective BRSKI_JP not formally defined and name is confusing #60

Open EskoDijk opened 9 months ago

EskoDijk commented 9 months ago

Problem with BRSKI_JP: it's used in an example as GRASP objective, but not formally introduced.

Also the name is a problem: it sounds like a Join Proxy advertising itself as a Join Proxy to Pledges. But that's not the case: the document says it's used by a Registrar to advertise its CoAPS (CoAP-over-DTLS) service. So to stay consistent with earlier and other work we should use e.g.

BRSKI_REG (given that BRSKI_REGISTRAR would be quite long)

Also this fits with the name

BRSKI_RJP

which can be interpreted as "BRSKI Registrar Join Proxy protocol". This is the special access protocol that uses a CBOR element.

EskoDijk commented 9 months ago

Update: the BRSKI_JP is actually defined in constrained-voucher. (Should it be moved?)

Maybe discuss here why the objective name is "BRSKI_JP" since the objective is for the registrar to announce itself? Or should we read objective the other way around i.e. "objective is for the Join Proxy to connect to me"? (confusing)

mcr commented 9 months ago

I think that the JP part referred to the protocol we are advertising, but it does seem wrong now.