Open Julian-MJK opened 4 years ago
An issue however: Placement
This button may just too much for the town tune editor, from a UX standpoint, it adds confusion, "Why use play when one can use preview" "What's the difference between play and preview" for example.
I believe a better option, if we still wish to have a preview feature, is to instead have a dropdown menu of sorts, which lets you select between the booper and the sampler, "Editor instrument", and "Bells preview" or something that clarifies what the difference is to someone who hasn't played Animal Crossing before. This range would select what instrument is used when the "play" button is pressed.
I'm really not too sure, personally I feel it adds too much confusion, it feels unecessary Perhaps this is too much, thoughts?
The reason this feature was initially considered, was because a lot of people have complained that the town tune sounds different in the editor from when it's played at the hour.
If the reason for these complaints was because of plain ignorance to how the Animal Crossing Town Tune editor works, then this feature has valuable a use (beyond just getting a better idea of what your tune will sound like). A confusion-&-clutter-free disclaimer could also solve this however.
If that isn't the reason for the complaints however, and the pitch-range inaccuracy fixed in PR #104 is the real reason for the confusion, then this feature is redundant.
Add a "Preview Tune" (as it plays on the hour) button to the Town Tune editor, clearing up some confusion on why the town tune sounds different when played on the hour, for those who haven't played AC games before, and giving people a chance to preview what the tune will actually sound like.
Should be as simple as playing the town tune like the "Play" button, but using createSampler() instead of createBooper() as the instrument.