animal-crossing-music-extension / ac-music-extension

Google Chrome extension that plays hourly Animal Crossing music and more while browsing!
https://acmusicext.com
zlib License
343 stars 57 forks source link

Check if frequencies[] array has correct pitch-frequencies #107

Open Julian-MJK opened 4 years ago

Julian-MJK commented 4 years ago

The frequencies in the frequencies[] array are used only by the Town Tune editor to play it's pitches using createBooper().

These frequencies seem inconsistent with the pitches they're assigned to, when looking at pitch->frequency conversion charts, so I suggest someone look over the frequencies in tune_player.js:5 frequencies[], checking if they are the right frequencies for the pitches at tune_player.js:2 availablePitches[].

If these frequencies are wrong, the town tune in the editor will sound different from when it's played at the hour.