search

animal-crossing-music-extension / ac-music-extension

Google Chrome extension that plays hourly Animal Crossing music and more while browsing!
https://acmusicext.com
zlib License
343 stars 57 forks source link

4.1.1 #109

Closed PikaDude closed 4 years ago

PikaDude commented 4 years ago

Fixes various issues regarding pitches of notes with the town tune editor and player, specifically removing the odd note F1 which caused most issues.

PikaDude commented 4 years ago

I was waiting for an approval from someone else other than the code author before merging :/ Try not to do this again.

Julian-MJK commented 4 years ago

I thought that you would want that, but you had specifically only requested a review from me, so despite thinking it was odd, I assumed that if you wanted more collaborators approval you would have requested it with the feature specifically built for communicating that.

I reviewed it and saw no further activity for about an entire day, so given the unusually important nature of the fix, and the continued influx of bug reports, I merged the seemingly fulfilled PR, assuming you were waiting for the code author to do so after all requirements were met. Still learning GitEtiquette after all, so sorry about misreading that.

Because this I don't see this entirely as my fault, but I definitely agree it was rushed of me, and I'll be much more careful about merging PR's next time.