search

animal-crossing-music-extension / ac-music-extension

Google Chrome extension that plays hourly Animal Crossing music and more while browsing!
https://acmusicext.com
zlib License
345 stars 58 forks source link

Google Drive link doesn't include New Horizons music #137

Closed Deozaan closed 4 years ago

Deozaan commented 4 years ago

The readme has a link to the music used by this extension, which is hosted on a Google Drive link. It seems that even though the extension has been updated to use the music from Animal Crossing New Horizons, the Google Drive link has not been updated.

paladique commented 4 years ago

Since 4.0 we've removed any dependency on this folder. It's defunct and no longer used so it will be removed from our documentation soon.

Deozaan commented 4 years ago

I thought the point of linking to the Google Drive folder with the music was to maintain the spirit of the open source nature of the extension and provide a link to the source audio files as well.

PikaDude commented 4 years ago

The Google Drive link was used for the older versions of the extension. If people downloaded a copy of the extension via GitHub, they also needed to download the required audio so the extension would work, as they were not bundled together. The Google Drive link is simply just there for legacy reasons and serves no purpose since newer versions now remotely stream the audio from an external source.

paladique commented 4 years ago

+1 and to add on to the open source part here - the music technically isn't ours. With that said it's probably wise to not keep a public link to this lying around.

Deozaan commented 4 years ago

Thanks for clarifying that for me.