search

animal-crossing-music-extension / ac-music-extension

Google Chrome extension that plays hourly Animal Crossing music and more while browsing!
https://acmusicext.com
zlib License
343 stars 57 forks source link

Tune town should only play when enabled #139

Closed paladique closed 3 years ago

paladique commented 4 years ago

Fixes #131

Logic in the StateManager.js only checked the absoluteTownTune setting, so the hourly tune/town tune would continue to play even when enableTownTune is false.

Decided to keep this change small and check the enableTownTune setting as well. Optionally, absoluteTownTune could be set to false/unchecked as well, but decided against altering user settings.

paladique commented 4 years ago

@ilikecorndogs any thoughts on preserving the "play while paused" setting and keeping it checked, even when town tune is unchecked?

PikaDude commented 3 years ago

fixes bug on opera gx, however, it appears to not play custom tunes while the music is paused, despite the options being selected correctly (both being checked). while music is unpaused with these settings, it plays. perhaps it is due to a lack of audio permissions to play audio? https://imgur.com/a/ONFYzrH options used in linked picture

I can't seem to reproduce this, even on Opera GX. Are you sure this is happening?