animal-crossing-music-extension / ac-music-extension

Google Chrome extension that plays hourly Animal Crossing music and more while browsing!
https://acmusicext.com
zlib License
345 stars 58 forks source link

Make town tune sound effects more accurate to the sounds in the games #52

Open PikaDude opened 4 years ago

PikaDude commented 4 years ago

Currently the sound effects in the town tune editor and when it actually plays aren't quite the same to the ones from the real games. Using dumps or rips from the files we could make them more accurate to most likely Animal Crossing New Leaf as it's the most modern and crisper sounding one.

Julian-MJK commented 4 years ago

I can try changing the oscillator values to fix this, I'll have a look at it.

Julian-MJK commented 4 years ago

Can you find any example audio/video of the town tune as it's played in-game in New Leaf? Can only find examples of Wild World, which the town tune sounds very similar to when played at the hour.

PikaDude commented 4 years ago

I can record each individual note and compile them if need be.

Julian-MJK commented 4 years ago

Seeing as the notes are somewhat off-pitch when played at the hour, that would be great

PikaDude commented 4 years ago

I have dumped and recreated the bell sounds from NL as located here. Each bell is exactly 11.821 seconds. It ranges from G1-E3 just like the game. https://erisly-i.s-the.best/8zUaPqU.ogg

Xane123 commented 4 years ago

Well, with my pull request's changes (#130), the hourly bell chime is definitely more accurate, though it's based on NH instead of NL (so the chime is actually played on-key). Interestingly, New Horizons' chimes are exactly 4 seconds long each, which matched your New Leaf bells.ogg version.

Also, my pull request slows down the bells (while leaving the town tune editor's playback unchanged), making it close to the game. @Julian-MJK helped me with some of the script edits, too.