animal-crossing-music-extension / ac-music-extension

Google Chrome extension that plays hourly Animal Crossing music and more while browsing!
https://acmusicext.com
zlib License
343 stars 57 forks source link

Fix: timekeeper's hourly check function #77

Closed PikaDude closed 4 years ago

PikaDude commented 4 years ago

Previously, timekeeper used to create a timeout function that would wait specifically until the hour ticks over to register the hourly change, and therefore change the music. This process is flawed in several ways:

I have updated the function to a SetInterval loop that runs every second, fixing all of the above issues, by running every second, and not waiting until a specific time, which will prevent it from getting desynced.

PikaDude commented 4 years ago

Save it for another time I reckon, we need to prioritise getting these fixes out.