search

animal-crossing-music-extension / ac-music-extension

Google Chrome extension that plays hourly Animal Crossing music and more while browsing!
https://acmusicext.com
zlib License
344 stars 57 forks source link

Update: remove need for tabs permission #82

Closed PikaDude closed 4 years ago

PikaDude commented 4 years ago

So I'm an idiot and thought we needed the "tabs" permission to check if tabs were playing audio. Nope I'm just a complete fool, we don't. At all. This PR completely removes it and changes the default tab audio behaviour option from "nothing" to "pause".

jordigarcl commented 4 years ago

WTF. I also reviewed the chrome.tabs docs for that PR and missed it as well. It's right there...

The majority of the chrome.tabs API can be used without declaring any permission. However, the "tabs" permission is required in order to populate the url, pendingUrl, title, and favIconUrl properties of Tab.

I just checked the Wayback Machine in case that was a recent clarification but no, it's always been there 🤡🤣

PikaDude commented 4 years ago

I swear I got a permission error too when I tried it without the perms, but I guess I was doing something different back then.