Closed Julian-MJK closed 4 years ago
Getting an error while playing the preview now
tune_editor.js:130 Uncaught TypeError: Cannot read property 'eachNote' of undefined
at HTMLButtonElement.playTune (tune_editor.js:130)
And when the town tune finishes playing on the hour, getting another error.
Error handling response: TypeError: Cannot read property 'done' of undefined
scripts/background/TownTuneManager.js:17 (anonymous function)
Apart from the errors mentioned above, the buttons and controls of the editor keep being disabled after the music stops playing. It is kind of broken in the current state.
Nevertheless I like the new design a lot!
Thanks for the feedback, this seems strange, I didn't have any of these issues when trying out this branch myself, I'll look into it
Should we also disable the townTuneVolume
when the TownTune is playing? I believe it'd be better UX, users may expect the music to change volume as it is playing.
Great 👍
Changed:
Added: