Enhancements & additions to the town tune editor & player

animal-crossing-music-extension / ac-music-extension

Google Chrome extension that plays hourly Animal Crossing music and more while browsing!

https://acmusicext.com

zlib License

343 stars 57 forks source link

Enhancements & additions to the town tune editor & player #83

Closed Julian-MJK closed 4 years ago

Julian-MJK commented 4 years ago

Changed:

Default town-tune to be more accurate to Wild World's default town-tune
Increased pitch range (Automatically sized max-value for the pitch sliders, some notes weren't selectable because the max-value wasn't high enough)

Added:

Separate volume for the town tune
Some documentation for the root tune_player.js methods
"Reset" & "Randomize" button for the town tune editor
Visual improvements to the town tune editor
'?' pitch

PikaDude commented 4 years ago

Getting an error while playing the preview now

tune_editor.js:130 Uncaught TypeError: Cannot read property 'eachNote' of undefined
    at HTMLButtonElement.playTune (tune_editor.js:130)

And when the town tune finishes playing on the hour, getting another error.

Error handling response: TypeError: Cannot read property 'done' of undefined
scripts/background/TownTuneManager.js:17 (anonymous function)

jordigarcl commented 4 years ago

Apart from the errors mentioned above, the buttons and controls of the editor keep being disabled after the music stops playing. It is kind of broken in the current state.

Nevertheless I like the new design a lot!

Julian-MJK commented 4 years ago

Thanks for the feedback, this seems strange, I didn't have any of these issues when trying out this branch myself, I'll look into it

jordigarcl commented 4 years ago

Should we also disable the townTuneVolume when the TownTune is playing? I believe it'd be better UX, users may expect the music to change volume as it is playing.

jordigarcl commented 4 years ago

Great 👍