search

animate1978 / MB-Lab

MB-Lab is a character creation tool for Blender 4.0 and above, based off ManuelBastioniLAB
Other
1.85k stars 315 forks source link

IK_control_ft_L rotate/move incorrect #166

Closed sykvbt1960 closed 4 years ago

sykvbt1960 commented 5 years ago

Please forgive my poor english. my problem is when rotate or move the _IK_control_ftL, the toes part behave strangely. the _IK_control_ftR works fine. I'm using MB-Lab 1.7.6 and Blender v2.80.75.

IK_control_ft_L

Thank you and sorry to trouble you so much!

animate1978 commented 5 years ago

Don't be sorry, this is what bug reports are for :)

I will look into it, though just to be safe you should do a test and Finalize the character first, then see if you get the same result.

sykvbt1960 commented 5 years ago

Thanks for your quick reply. After Finalize the character, the result still same, i try MBLab1.7.1, still the same, but it go fine with 1.6.2a version. Please take a look of it when you have time and thanks for your hard working to keeping MBLab alive. Thanks!

sykvbt1960 commented 5 years ago

Hi, Sorry to bother you again. i found out if i created the character with BOTH the "Use Inverse Kinematic" and "Use basic musics" options selected then everything is ok. Thanks a lot!

mklemarczyk commented 4 years ago

@sykvbt1960 Can I ask you to attach the blender file for investigation? I want to investigate the situation, since strange behaviour was affecting only left side.

@animate1978 you can assign me to this issue. I will try to investigate it and report progress by November 11th.

sykvbt1960 commented 4 years ago

@mklemarczyk Thanks for your concern, here i attach the .blend file. actually just create a new character with use IK can get the same result. by the way, the IK_control_hl_R also got a little strange reaction for the toes, but not so noticed... here is the .blend file i generate, sorry i had to zip it cause i don't know how to attach the raw .blend file here. IK issue.zip Thanks for for you and all others who give work to MB-Lab. Thanks!

mklemarczyk commented 4 years ago

@sykvbt1960 no problem with zip, it will download faster. Thank you. I will look into it.

mklemarczyk commented 4 years ago

Is it the same behaviour if you finalise the character? I found that the character you sent is not finalised. Setting the pose should be done after creation finalisation step.

Site notice: Dev version 1.7.7 does not recognise the not finalised model. @animate1978 does something important changed?

After further investigation, I found that axes are not aligned between toes_L and IK_control_ts_L bones, the same for right side (but axes are less misaligned). Bone toes_L/toes_R is copying rotation from IK bones, that's why it ends up in strange pose of toes.

Left (axes wrong): image Right (axes wrong): image

@animate1978 bones roll property need to be adjusted. For not know reason for me, those bone axes are aligned when IK is created with muscle system.

IK with muscle left (axes OK): image

IK with muscle right (axes OK): image

sykvbt1960 commented 4 years ago

@mklemarczyk thanks for your quick replied. yes, after finalized, the result is still the same, but if create the character with "Use basic musics" also selected, then everything seems ok. by the way, i'm using MB-Lab 1.7.6 and blender v2.80.75. thnaks again for both of you @mklemarczyk and @animate1978 !

animate1978 commented 4 years ago

This should be fixed now, if you clone the "Developmental" branch

mklemarczyk commented 4 years ago

@animate1978 I will cross check it tomorrow and send results.

mklemarczyk commented 4 years ago

@animate1978 verified with commit 2c8c3a7 on dev branch. Problem still exists.

animate1978 commented 4 years ago

bad_ik_01

Ok I finally see what it's doing, for some time I could not figure out how to replicate this bug.

This is a finalized model as well.

mklemarczyk commented 4 years ago

I found the issue: The armature MBLab_skeleton_base_ik in file humanoid_library.blend is wrong. The feet bones need to be fixed. Who is in charge of this file? I do not want to modify it, because it is basic blender file.

Warning: The same error exists on master. I recommend to fix it and release new version as soon as the dev is stable and ready to use. I mean all new features works always.

animate1978 commented 4 years ago

I will be looking at it tonight after work

mklemarczyk commented 4 years ago

I started to think about better format for storing the information that are stored in this file. Current format makes it not possible to compare changes done within commit. The GitHub is not able to create diff .blend files.

animate1978 commented 4 years ago

I am still on this, I might need to call for help on this one I don't know. Rigging is not one my strong suites.

As for changing the file formats, this has been discussed before, I have no issue with it really, I mean the mesh can be stored as say OBJ file format, however the shader information would have to remain in a blend file, unless we go Principled BSDF again, with the old texture maps back, and the work that Noizirom is doing for the hair shader could be expanded for the skin... anyway that is another topic for another issue.

animate1978 commented 4 years ago

With this commit, the IK and the IK / Muscle rigs SHOULD be fixed now

https://github.com/animate1978/MB-Lab/commit/51cdec4c34034f71301cb36b7e124f498be603a4

I have done basic testing with both rigs, focusing on the feet since these were the trouble spots.

EDIT - this fix is in the dev branch

sykvbt1960 commented 4 years ago

@animate1978 Thanks to you and ALL other persons who involved in this bug fixed... Thanks for all your hard working... Thank You!