search

animate1978 / MB-Lab

MB-Lab is a character creation tool for Blender 4.0 and above, based off ManuelBastioniLAB
Other
1.83k stars 315 forks source link

Lights programmed in rather than Appended #236

Closed animate1978 closed 4 years ago

animate1978 commented 4 years ago

Is your feature request related to a problem? Please describe. I've had this idea for some time, to remove the lights in the humanoid_library.blend file, to then replace it with code that adds the lights.

Describe the solution you'd like Removal of lights in humanoid_library.blend will not really reduce it's size much but it will keep the blend file for just meshes and armatures.

Describe alternatives you've considered Removing the lighting option has been considered but it is a nice option to have this feature still

Noizirom commented 4 years ago

I think that the lights should be done via python, but I also think we might need the lights tweaked to better mimic a 3 point lighting system. I've been looking for an article I saw on setting up lights for still renders to show what I mean.

On Tue, Feb 11, 2020, 11:52 PM animate1978 notifications@github.com wrote:

Is your feature request related to a problem? Please describe. I've had this idea for some time, to remove the lights in the humanoid_library.blend file, to then replace it with code that adds the lights.

Describe the solution you'd like Removal of lights in humanoid_library.blend will not really reduce it's size much but it will keep the blend file for just meshes and armatures.

Describe alternatives you've considered Removing the lighting option has been considered but it is a nice option to have this feature still

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/animate1978/MB-Lab/issues/236?email_source=notifications&email_token=AKYHC3SQRCD7HO4S3GQOIA3RCN6ARA5CNFSM4KTSUBI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IM2FLVQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKYHC3TGB7MS76HJDAI4HZTRCN6ARANCNFSM4KTSUBIQ .

Noizirom commented 4 years ago

All you would need to copy from the current setup is the settings and the matrix_world. (Because it contains all the info you need to place them. i.e. location, rotation, scale, etc...)

On Tue, Feb 11, 2020, 11:58 PM Zion Hill Hill noizirom@gmail.com wrote:

I think that the lights should be done via python, but I also think we might need the lights tweaked to better mimic a 3 point lighting system. I've been looking for an article I saw on setting up lights for still renders to show what I mean.

On Tue, Feb 11, 2020, 11:52 PM animate1978 notifications@github.com wrote:

Is your feature request related to a problem? Please describe. I've had this idea for some time, to remove the lights in the humanoid_library.blend file, to then replace it with code that adds the lights.

Describe the solution you'd like Removal of lights in humanoid_library.blend will not really reduce it's size much but it will keep the blend file for just meshes and armatures.

Describe alternatives you've considered Removing the lighting option has been considered but it is a nice option to have this feature still

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/animate1978/MB-Lab/issues/236?email_source=notifications&email_token=AKYHC3SQRCD7HO4S3GQOIA3RCN6ARA5CNFSM4KTSUBI2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IM2FLVQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKYHC3TGB7MS76HJDAI4HZTRCN6ARANCNFSM4KTSUBIQ .

animate1978 commented 4 years ago

Yeah I've been playing with code inside Blender itself this time, the rotation I can't seem to nail and the code is um....basic at best lol

I've also looked at the 3 point lighting add code that comes with Blender so may borrow from there too

ldo commented 4 years ago

If you are looking for an article on various kinds of portrait lighting, there is one saved at archive.org here.

Noizirom commented 4 years ago

@Ido thanks. What I was looking for had different color lights. Like one yellowish, the back one blueish. Something like that. @animate1978 if you copy the matrix_world of the original lights and make the python lights matrix_world set to the original copy, then the locations and rotations should take care of themselves. Just add the light to the origin (0,0,0)

On Wed, Feb 12, 2020, 12:23 AM ldo notifications@github.com wrote:

If you are looking for an article on various kinds of portrait lighting, there is one saved at archive.org here https://web.archive.org/web/20140606102536/http://www.professionalphotography101.com/portrait_lighting/lighting_names.html .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/animate1978/MB-Lab/issues/236?email_source=notifications&email_token=AKYHC3SNXRDFJQXKR34K5A3RCOBWPA5CNFSM4KTSUBI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELPO64Q#issuecomment-585035634, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKYHC3T3ZFQ4EDA7DYMYEVTRCOBWPANCNFSM4KTSUBIQ .

ido commented 4 years ago

@Noizirom i think you meant @ldo (Lawrence) not @ido (me).