animate1978 / MB-Lab

MB-Lab is a character creation tool for Blender 4.0 and above, based off ManuelBastioniLAB
Other
1.76k stars 308 forks source link

Finalising error, "roughness" #405

Open Chrysivey opened 3 months ago

Chrysivey commented 3 months ago

Hiya there,

using MB-Lab for the first time, so let me thank you all for the great work continuing this.

I came across an error when finalising a model keyword "roughness", Py trace led to a file in AppData "materialengine.py". This line was commented out, removed the "#" and it seemed to worked. "roughness": character_config["texture_roughness"],

Was this intentional?

Logs I'm afraid I already restarted Blender.

Thanks all!

animate1978 commented 3 months ago

This bug has been addressed and is in the master branch.

Yes the removal of the Roughness map was intentional, because there is no map for it in the shader, problem was that I did not fully test out the code before publishing. This is why you are getting the error. What you did was acceptable as well it just won't render the map out on the shader. The reason I haven't fully removed the Roughness map from the project is because in the future I may add it back in. I may not. At this point I am not sure because the Roughness doesn't seem to be needed for the skin shader but I am hesitant on purging it just yet.