search

anime-dl / anime-downloader

A simple but powerful anime downloader and streamer.
The Unlicense
1.93k stars 217 forks source link

Add ability to make nyaa episodic #551

Open AbdullahM0hamed opened 4 years ago

AbdullahM0hamed commented 4 years ago

Couldn't help myself - nyaa must conform.

A lot of testing is needed. To simplify testing, simply replace [('no_extractor', magnet_link)] to [('no_extractor', url)] and check the titles from those links to see that the episodes are being picked up and in the correct order. Episodic must be set to True (set to False by default because this is very experimental).

codecov[bot] commented 4 years ago

Codecov Report

Merging #551 into master will decrease coverage by 0.24%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   16.79%   16.54%   -0.25%     
==========================================
  Files         117      117              
  Lines        4580     4647      +67     
==========================================
  Hits          769      769              
- Misses       3811     3878      +67
Impacted Files Coverage Δ
anime_downloader/config.py 51.78% <ø> (ø)
anime_downloader/sites/nyaa.py 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 021785e...416c384. Read the comment docs.

IguanasInPyjamas commented 4 years ago

Feels runtime man

AbdullahM0hamed commented 4 years ago

Should be much faster now. Scrape_episodes_episodic really needs work though

codecov-io commented 3 years ago

Codecov Report

Merging #551 (416c384) into master (308a5de) will decrease coverage by 4.23%. The diff coverage is 4.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   20.78%   16.54%   -4.24%     
==========================================
  Files         100      117      +17     
  Lines        3806     4647     +841     
==========================================
- Hits          791      769      -22     
- Misses       3015     3878     +863
Impacted Files Coverage Δ
anime_downloader/__version__.py 0.00% <0.00%> (ø)
anime_downloader/animeinfo.py 0.00% <0.00%> (ø)
anime_downloader/cli.py 0.00% <0.00%> (ø)
anime_downloader/commands/config.py 0.00% <0.00%> (ø)
anime_downloader/commands/dl.py 0.00% <0.00%> (ø)
anime_downloader/commands/ezdl.py 0.00% <0.00%> (ø)
anime_downloader/commands/test.py 0.00% <0.00%> (ø)
anime_downloader/commands/watch.py 0.00% <0.00%> (ø)
anime_downloader/config.py 51.78% <ø> (ø)
anime_downloader/downloader/http_downloader.py 24.59% <0.00%> (-0.84%) :arrow_down:
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d20769...eaabcf9. Read the comment docs.

ArjixWasTaken commented 3 years ago

Is this abandoned or not? I doubt iggy is going to actually give a review as requested.

AbdullahM0hamed commented 3 years ago

Iirc this was working and I was just waiting on a review