search

animebook / animebook.github.io

In-browser video player for learning Japanese with subtitles
https://animebook.github.io
MIT License
273 stars 29 forks source link

Certain videos not working with Chromium Woolyss all-codecs+ #35

Closed msw93 closed 3 years ago

msw93 commented 3 years ago

Not sure if this is the right place for this kind of issue. But certain video files are not loading even with Chromium Woolyss all-codecs+ . Was able to reproduce on a different machine. Maybe I should bring this to the chromium team?

Not sure if I can post video source here.

image image

soamsy commented 3 years ago

I've noticed this issue show up with a few anime releases lately, and looking into it I realized there's an error message from Chromium I should be showing when this happens, so I added it to the page. image

DECODER_ERROR_NOT_SUPPORTED: audio decoder initialization failed

Can you try loading the video again? I want to see what error you get.

soamsy commented 3 years ago

Also fwiw, there is an in progress Chromium bug that deals with the error message I have about "audio decoder initialization failed" https://bugs.chromium.org/p/chromium/issues/detail?id=1245123 Not sure if it's related since it's about AAC audio while my video uses EAC3, but it hints to me that there's activity around audio playback in Chromium right now.

msw93 commented 3 years ago

Thanks for adding the error msg,

I am getting the same error as you!

image

soamsy commented 3 years ago

So, my conclusion after playing around with this is that Woolyss Chromium doesn't like AC3 audio. I started using some other video files, and none of them work if they use AC3. I was convinced this was maybe a regression in Chromium for a second, but I decided to look at the all-codecs+ description on the woolyss site, and it doesn't actually mention AC3 as being supported. image Meaning, what I thought was supported is not, and since anime releases don't use AC3 that often, I conveniently never encountered this until recently. I'll work on updating the README with this, but the answer for now should be to avoid anime releases that use AC3 audio if you can.

Also to note, https://killergerbah.github.io/asbplayer/ plays the video files fine, but the audio is all muted. It probably gets away with this by ignoring the error and playing the file anyway.

msw93 commented 3 years ago

I see! Thanks for looking into this!

I probably shouldn't hold my breath for this to be added? 😅

Does the chromium github have a section for feature reqs?

soamsy commented 3 years ago

https://bugs.chromium.org/p/chromium/issues/detail?id=611517 Case has been around for 5 years, so I wouldn't hold out on it, yeah.

msw93 commented 3 years ago

Played around with some stuff last night. Converting the audio to aac makes the videos play! 👍

I used this superuser answer, I had to tinker with the ffmpeg installation and the script options, but it works really well, one click and you can batch convert all videos in a folder. Takes only a minute or so per show!

I think this is a good solution for Windows users, but might be a touch high level to set up 😂