animebook / animebook.github.io

In-browser video player for learning Japanese with subtitles
https://animebook.github.io
MIT License
273 stars 29 forks source link

[Bug] Subtitle size not adjustable with browser zoom after update #60

Closed msw93 closed 2 years ago

msw93 commented 2 years ago

The older version, we could adjust sub size with browser zoom, that feature is now gone with the addition of the font size slider.

Not sure if this is intentional?

User browser zoom was faster and more convenient from my perspective.

soamsy commented 2 years ago

Yeah, it's intentional. Although I originally liked being able to quickly control + zoom to get the subs right, I realized 95% of my zooming was because I was switching from fullscreen to a smaller window resolution, and the subs' size wasn't staying in sync with my video resizing. Many other video players will scale subtitles as you resize the video player, so I figured it was weird that animebook didn't do the same.

This isn't hard to implement in browsers with font-size: px vs font-size: vmin, but having it scale with window size means browser zoom stops working on it, so I added the slider as a way to still be able to adjust it. A bit of a compromise if you need to zoom a lot, but I barely bother with the slider's zoom now that the subtitles grow with the window.

msw93 commented 2 years ago

I see. That makes sense.

My use case is I usually watch at my computer desk. But I have a couch behind my desk which I watch from sometimes to relax, but the subs are too small generally so increase the size about 50 percent.

I will just have to get accustomed to the slider. Is there any way to hot key the slider?

soamsy commented 2 years ago

I can do hotkeys, just updated. Try hitting - and = next time you load a video, and it should update the subtitle size.

msw93 commented 2 years ago

Thank you! 🙏