animeshkundu / youtube-audio

Disable videos on youtube and save battery and bandwidth / data
https://addons.mozilla.org/en-US/firefox/addon/youtube-audio
GNU General Public License v3.0
174 stars 39 forks source link

Fix host permissions #12

Open NathanJRollins opened 5 years ago

NathanJRollins commented 5 years ago

The correctly formatted host permissions for YouTube's domain are "*://*.youtube.com/*".

The current formatting (as of 305f5bbf3b4d4bdbac015330546ad92e183496c4 ) will not allow the extension to be loaded. An error is displayed when you try.

Even with the correct formatting however, the extension fails to work correctly. It simply doesn't remove the video as intended. Reverting to the wildcard permissions of a couple commits ago ( "*://*/*" ) rectifies this.

So we need to either revert the project to 7dede357835d986741e206978c4e7a30d3e7c946 or discover a way to make it function within a more limited scope of permissions.

NathanJRollins commented 5 years ago

I've created a pull request aiming to revert this to a functional state until another solution is found. -> #13