search

animikhroy / rk_toolkit_pipeline_diagrams

Master-repository for all code related to "A Novel Approach to Topological Graph Theory with R-K Diagrams and Gravitational Wave Analysis"
https://arxiv.org/abs/2201.06923
2 stars 0 forks source link

Remove unnecessary files #13

Closed andorsk closed 1 year ago

andorsk commented 2 years ago

Clean and remove any unnecessary files.

ghost commented 1 year ago

Hey @andorsk , I think the unnecessary files have already been addressed by you. I have no idea which ones are unnecessary for the publishing and notebook folders, but for rktoolkit, I think thats been migrated, so deleting the TO_DELETE folder should be fine for the toolkit. I would ask @animikhroy to check for the other files that are not part of the toolkit to see if theres anything necessary.

ghost commented 1 year ago

I think the helpers file from TO_Delete might be needed as thats been referred to in the common.py folder. Please check if its the case or the helpers file code is migrated to another file already.

ghost commented 1 year ago

There's a helpers.py file in the other notebook folders to supplement this, so either I should move the helpers.py file from the rk_gw_mma or rk_general_applications to common folder or relatively import them (which may cause issues). This is also related to common.py issue so pasting there too.

animikhroy commented 1 year ago

Hey @andorsk , I think the unnecessary files have already been addressed by you. I have no idea which ones are unnecessary for the publishing and notebook folders, but for rktoolkit, I think thats been migrated, so deleting the TO_DELETE folder should be fine for the toolkit. I would ask @animikhroy to check for the other files that are not part of the toolkit to see if theres anything necessary.

@Ashxyz998 I dont see anything unnecessary in the toolkit unless there are repetitions I looked over like the one you pointed out for helpers.py. If you find anything like that then notify or tag it other wise we are good on this issue.

andorsk commented 1 year ago

ok. I will close this issue. thanks!