search

animikhroy / rk_toolkit_pipeline_diagrams

Master-repository for all code related to "A Novel Approach to Topological Graph Theory with R-K Diagrams and Gravitational Wave Analysis"
https://arxiv.org/abs/2201.06923
2 stars 0 forks source link

Migration work: Refactoring. #3

Closed andorsk closed 2 years ago

andorsk commented 2 years ago

Another big PR. Unfortunately there's probably going to be a few more before things are going to stabilize. Particularly since history is all messed up right now.

andorsk commented 2 years ago

@animikhroy this is the branch I'm working on right now.

animikhroy commented 2 years ago

@andorsk I can't seem to access 01_rk_toolkit @ 5335e82 as it is showing an error message. The rest of the folders are accessible and will get back to you after a review session with Dr. Ravi in the evening.

andorsk commented 2 years ago

@animikhroy fixed. i had some local commits that i hadn't pushed over to master. you should be able to access things now.

animikhroy commented 2 years ago

@andorsk thanks a lot 01_rk_toolkit @ 5335e82 is now accessible and is working fine.

animikhroy commented 2 years ago

@andorsk Requesting another urgent help. I am unbale to pull origin from the main branch due to the following unexpected error. error: invalid path 'pruned/04_publications/arxiv/A Novel Approach to Topological Graph Theory with R-K Topohedrons/aux' Updating 43ed35c..994f5d6

Need your help to fix this before I am able to pull the latest state of the main branch and then push the latest updates on the revised and formatted papers for PR-D&X.

andorsk commented 2 years ago

As part of the refactoring, some things broke. I'll be holding off on merging this PR until things are working. @Ashxyz998 lmk if you have any questions.

re: some of the tests, there is some old tests that will need to update to work with some of the newer code.

andorsk commented 2 years ago

@andorsk Requesting another urgent help. I am unbale to pull origin from the main branch due to the following unexpected error. error: invalid path 'pruned/04_publications/arxiv/A Novel Approach to Topological Graph Theory with R-K Topohedrons/aux' Updating 43ed35c..994f5d6

Need your help to fix this before I am able to pull the latest state of the main branch and then push the latest updates on the revised and formatted papers for PR-D&X.

This was resolved.

andorsk commented 2 years ago

Merging into master now. I've made number of comments, refactored a number of things, and the notebook ligo.ipnyb is working locally with the updated rk_toolkit.

andorsk commented 2 years ago

@Ausresh

Is this resolved?

On Sat, Sep 17, 2022 at 8:54 PM Ausresh Sarangu @.***> wrote:

@andorsk https://github.com/andorsk Requesting another urgent help. I am unbale to pull origin from the main branch due to the following unexpected error. error: invalid path 'pruned/04_publications/arxiv/A Novel Approach to Topological Graph Theory with R-K Topohedrons/aux' Updating 43ed35c https://github.com/animikhroy/rk_toolkit_pipeline_diagrams/commit/43ed35ca754263dcec871692ccf8a32689a5cea1 ..994f5d6 https://github.com/animikhroy/rk_toolkit_pipeline_diagrams/commit/994f5d65cd03d9c7a512c3fe9cae63b4371073b1

I am facing the same issue when trying to clone the repo using gitbash. For now I have downloaded the zip for main branch to check the code.

— Reply to this email directly, view it on GitHub https://github.com/animikhroy/rk_toolkit_pipeline_diagrams/pull/3#issuecomment-1250185063, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBUXXYO437FLJO3S7UEXR3V62HA3ANCNFSM6AAAAAAQJ3VLMA . You are receiving this because you were mentioned.Message ID: @.***>

ghost commented 2 years ago

Yes it is resolved. I can clone it now.