search

animina-dating / animina

👫❤️ ANIMINA Dating Platform
https://animina.de
Other
16 stars 6 forks source link

Refactor/translations, closes #1071, closes #1072, closes #1073 #1070

Closed briankariuki closed 1 week ago

briankariuki commented 1 week ago

we should merge this after po files with flag and category translations are added

wintermeyer commented 1 week ago

we should merge this after po files with flag and category translations are added

Do we have the English po files? Where?

briankariuki commented 1 week ago

we should merge this after po files with flag and category translations are added

Do we have the English po files? Where?

No. We have flags.txt and the seed_flags migration with the german and english translations

wintermeyer commented 1 week ago

@briankariuki But ist should already work or not? Just only for English right now. Because than we can merge and create a separate issue for the po files. Since we are beta I would be fine with this approach.

briankariuki commented 1 week ago

@briankariuki But ist should already work or not? Just only for English right now. Because than we can merge and create a separate issue for the po files. Since we are beta I would be fine with this approach.

Right now it will just show the english name of the flag/category as it is in the database.

wintermeyer commented 1 week ago

Right now it will just show the english name of the flag/category as it is in the database.

That is good enough. I prefer to take it online sooner rather than later. I'll take care of the German translation later.

wintermeyer commented 1 week ago

@briankariuki Please request a review when you feel this PR is production ready (all but the German translations).