search

animint / gallery

0 stars 4 forks source link

Porting the 57th visualization gallery from the NAU rcdata server #10

Closed nhintruong closed 2 months ago

nhintruong commented 2 months ago

I am updating the 57th data viz from the NAU rcdata server to GitHub Pages animint gallery

Here is the preview: https://nhintruong.github.io/breakpoints/

tdhock commented 2 months ago

thanks! as we discussed earlier, can you please close this pr and re-make one like #9 from your fork (nhintruong/gallery branch gh-pages), with a link to your fork of the updated gallery? The existing documentation for this process is here https://github.com/animint/gallery?tab=readme-ov-file#add-your-data-viz-to-the-gallery in particular 7. Make sure your pull request description has a link to the rendered version of your fork of the gallery, such as https://your_github_username.github.io/gallery/. That way, reviewers can quickly preview what the new gallery would look like after merging the pull request. do you understand that? if not, can you please suggest clarifications?

nhintruong commented 2 months ago

thanks! as we discussed earlier, can you please close this pr and re-make one like #9 from your fork (nhintruong/gallery branch gh-pages), with a link to your fork of the updated gallery? The existing documentation for this process is here https://github.com/animint/gallery?tab=readme-ov-file#add-your-data-viz-to-the-gallery in particular 7. Make sure your pull request description has a link to the rendered version of your fork of the gallery, such as https://your_github_username.github.io/gallery/. That way, reviewers can quickly preview what the new gallery would look like after merging the pull request. do you understand that? if not, can you please suggest clarifications?

Thank you for your guidance. I created a new PR here following your comment https://github.com/animint/gallery/pull/12