Open nhintruong opened 2 months ago
hi, thanks. This is a good start. The new version you made has black bars and overlapping text, which make it difficult to read.
The old version (below) uses alpha=0.5 for the geom_bar, and showSelected for the geom_text. Can you please update?
Hi, thank you for your reminder about the code issue. I'll update it to improve the visualization's clarity and readability.
I've added 3 new data visualizations, but I've noticed that they will automatically commit to this PR if it's unmerged. As a result, I couldn't create separate PRs for each visualization as we previously discussed. Do you have any suggestions to address this? Thank you very much for your guidance
I couldn't create separate PRs for each visualization as we previously discussed. Do you have any suggestions to address this?
It's not ideal but let's just review them all in this PR.
there are two different rows with the same name "Constrained Pruned Dynamic Programming Algorithm" Can you please rename them so that they are different? "Constrained Pruned Dynamic Programming Algorithm (6 data)" etc?
In the Constrained Pruned Dynamic Programming Algorithm visualizations there is some issue with the geom_line, which looks overplotted.
the original looks like below. The important difference is the geom_line should look like a curve (not a whole shaded area) maybe you need to specify aes(group) or showSelected?
"Penalty Learning" name should be changed to "Max margin interval tree" And the interaction is missing. You should be able to click the bottom plots and see updates. I notice the source links are still under github.com/tdhock -- can you please change these source links to point to your forks of the code, so we can see what modifications you made in order to get these exact results?
I notice the source links are still under github.com/tdhock -- can you please change these source links to point to your forks of the code, so we can see what modifications you made in order to get these exact results?
This is still an issue, can you please fix? These are the links under the "source.link" column -- can you please change them to point to your forks of the code, under github.com/nhintruong ?
For https://nhintruong.github.io/Central-American-temperature-maps/ there is an issue with the color of background (add theme_bw()?)/alpha transparency of geom_lines (should be darker and use color=violet, color_off=black) see your new version left below, old version right below
in World Bank (animint paper version) the geom_text is not in the right place (see your version below left), is there a missing showSelected? the geom_text should follow the geom_point, updated every year (old version below right)
several issues with your new version of montreal bikes data viz, see below left
too many models plotted, is geom_segment missing showSelected? your new version below left old version below right Also title is "intreg BIC" but should be changed to the old title, "Segmentation model selection with BIC" Also that file https://github.com/tdhock/animint/blob/master/inst/examples/intreg.R has many different data viz, which is confusing to use for a source link. User may ask, which code in that file was used to make this particular data viz that I am looking at? Please separate code into different files, one for each data viz.
there are two pairs of data viz with the same name,
in general, please use the same names as the old gallery, unless you need to change one of them to make them have a unique name in the new gallery
please do not add any more data viz to this PR. Let's try to fix the issues with these data viz and merge this PR, before attempting to port others.
I updated the new data viz from the NAU rcdata server.
This is the rendered version of my fork of the gallery for your preview: https://nhintruong.github.io/gallery/
Could you please review this new gallery update? Thank you very much for your guidance