animist-io / wowshuxkluh

Ionic / Ethereum module to help mobile Dapps run location contingent smart-contracts over Bluetooth LE.
http://animist.io
ISC License
6 stars 1 forks source link

Eth-lightwallet salt vulnerability. #28

Closed cgewecke closed 7 years ago

cgewecke commented 8 years ago

https://github.com/ConsenSys/eth-lightwallet/issues/109

'The new KeyStore constructor has been deprecated in favor of KeyStore.createVault(), and will be removed in a future version. Read issue #109 for info. https://github.com/ConsenSys/eth-lightwallet/issues/109'

cgewecke commented 7 years ago

Eth-lightwallet prints the warning even if you update code to use createVault AND karma's log-level options are totally fake! (cool) - so . . . moved lightwallet.js to /lib, npm uninstalled it, and commented out the perma-warn-flag at line 332 in the lightwallet file.

In effect eth-lightwallet is pinned at v. 2.5.3 but since we're just using this to test now per #36, that should be fine.