animo / paradym-wallet

With Paradym Wallet, you can seamlessly manage and present your digital credentials
https://paradym.id
Apache License 2.0
32 stars 12 forks source link

Possible documentation update: EXPO_USE_METRO_WORKSPACE_ROOT=1 to build #109

Closed tbloomfi closed 2 months ago

tbloomfi commented 5 months ago

I was getting a 404 error for the expo-router and was only able to run the app after exporting EXPO_USE_METRO_WORKSPACE_ROOT=1 as per the monorepo instructions.

Should this be added to the build instructions or added automatically in the package.json file?

TimoGlastra commented 4 months ago

Hmm I've been able to build it fine without that command. What command are you adding this to? And from which directory are you running the app?

timbl-ont commented 4 months ago

Just tested again with a fresh clone of the main branch with the same result - via Android simulator.

Node Version: v18.20.2

I followed the Readme:

yarn
cd apps/expo
yarn prebuild
yarn android

Screen shot:

Screenshot 2024-06-04 at 11 42 31 AM

The same steps after running "export EXPO_USE_METRO_WORKSPACE_ROOT=1" in the shell fixed the error, launching the wallet. This setting is from here: "https://docs.expo.dev/guides/monorepos" - the note on Expo Router.

TimoGlastra commented 4 months ago

Okay thanks for looking into it! @berendsliedrecht something you can add with the restructure soon?

berendsliedrecht commented 4 months ago

Yes, I'll pay attention to it!

TimoGlastra commented 3 months ago

I ran into the same issue -- have fixed it locally and will open a PR. Thanks for reporting @timbl-ont