animo / paradym-wallet

With Paradym Wallet, you can seamlessly manage and present your digital credentials
https://paradym.id
Apache License 2.0
32 stars 12 forks source link

feat: wallet screen detail screen #148

Closed TimoGlastra closed 1 month ago

TimoGlastra commented 2 months ago

Adds stuff for the wallet screen and detail screen. Activity is stil todo.

@janrtvld some things maybe you could help with:

https://github.com/user-attachments/assets/c20f351c-2de9-4473-8162-ec650e3edd7a

janrtvld commented 1 month ago

I'll take a look at it now.

janrtvld commented 1 month ago

showing toast in a modal screen (doesn't work atm -- needed for biometric failed toast)

Will look into this.

i think on wallet screen we don't want a header?

Ideally we do it when you scroll, the header will scroll under the top navigation and a smaller version appears in the top navigation. Like this: https://imgur.com/a/84iq0BP

on the pid detail screen we want to hide it on scroll maybe?

Hmm, I wouldn't bother for now. The current way has the back button always visible which I think is better UX.

how to style the credential attributes rows background color differently in paradym vs ausweis wallet?

Probably a 'theme' or 'variant' property on which you use to style the TableContainer or TableRow with the correct colour.

janrtvld commented 1 month ago

You can render toast inside a modal screen by rendering <ToastViewport /> inside the screen component.

berendsliedrecht commented 1 month ago

For after funke, we should probably check how we would like to display booleans. Because the age over thingy is quite weird unless you know the underlying data model.

TimoGlastra commented 1 month ago

For after funke, we should probably check how we would like to display booleans. Because the age over thingy is quite weird unless you know the underlying data model.

Worked, thanks!