search

animo / paradym-wallet

With Paradym Wallet, you can seamlessly manage and present your digital credentials
https://paradym.id
Apache License 2.0
32 stars 12 forks source link

feat: receiving and sharing qeaas #181

Closed janrtvld closed 1 week ago

janrtvld commented 2 weeks ago

https://github.com/user-attachments/assets/f28263c1-5e58-4526-9ec0-74a6662dac38

janrtvld commented 1 week ago

@TimoGlastra added a video. I think it's easiest of you just run it and test it and lmk if you run into anything.

TimoGlastra commented 1 week ago

Video looks nice! Thanks. I'm only not so sure about the share overlay with yellow top and then the shared attributes below on white. I think it should look a bit more like a card maybe? It's quite a big contrast. Can't we add an overlay with a certain transparency so white text on top of it is always visible (or black text)?

Also -- does it support multiple credentials being presented?

TimoGlastra commented 1 week ago

Also -- we can do this later, but i think we might have to tweak the UI just a little bit so it's not exactly the NL wallet design (i think it's good inspiration, but also no need for it to look 100% the same i think?)

TimoGlastra commented 1 week ago

Both can be improved later, this is already a very good improvements, so good to merge on my side 🙌

janrtvld commented 1 week ago

Video looks nice! Thanks. I'm only not so sure about the share overlay with yellow top and then the shared attributes below on white. I think it should look a bit more like a card maybe? It's quite a big contrast. Can't we add an overlay with a certain transparency so white text on top of it is always visible (or black text)?

Also -- does it support multiple credentials being presented?

Can you share a screenshot of what you mean? I'm not following.

The UI supports sharing multiple credentials but there is an error thrown from a lower level so I've created a ticket out of it.

janrtvld commented 1 week ago

Also -- we can do this later, but i think we might have to tweak the UI just a little bit so it's not exactly the NL wallet design (i think it's good inspiration, but also no need for it to look 100% the same i think?)

Yes, this is in the back of my mind. I've already changed the view of attributes back to what we have in the Paradym wallet. This makes it stand out a bit more. Still thinking about a different view for the home cards as well.

TimoGlastra commented 1 week ago

Can you share a screenshot of what you mean? I'm not following.

image

Also it seems sanitazion capitalizes the string, but does not remove _

TimoGlastra commented 1 week ago

The UI supports sharing multiple credentials but there is an error thrown from a lower level so I've created a ticket out of it.

That will be resolved by #180, but we need to wait for a new release of PEX. For Paradym wallet this PR is already released. For funke we will have to wait a bit