search

animo / siera-desktop

https://siera.animo.id/desktop
8 stars 3 forks source link

feat: add did resolver #123

Closed TimoGlastra closed 1 year ago

TimoGlastra commented 1 year ago

Adds support resolving did documents. Wasn't 100% about how to show the form + then the JSON of the did document. Any feedback on how to display it differently is welcome!

Trying to add some screenshots but internet is scarce...

https://user-images.githubusercontent.com/23165168/232320616-943fdcf2-a5f2-4e47-a37a-ad6c5bdf13a5.mov

berendsliedrecht commented 1 year ago

Do you think we should show the supported did methods? Might be nice to check out the unresolver for some inspiration.

codecov-commenter commented 1 year ago

Codecov Report

Merging #123 (e754cc6) into main (ea90fdb) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #123   +/-   ##
=======================================
  Coverage   76.74%   76.74%           
=======================================
  Files          11       11           
  Lines          43       43           
  Branches        3        3           
=======================================
  Hits           33       33           
  Misses         10       10

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

TimoGlastra commented 1 year ago

Do you think we should show the supported did methods? Might be nice to check out the unresolver for some inspiration.

Yeah that's a good idea. I tried to extract them based on the registered ones, but it's quite hard to do in 0.3.x. If we update to 0.4.x it would be simpler to extract the registered methods.

berendsliedrecht commented 1 year ago

Do you think we should show the supported did methods? Might be nice to check out the unresolver for some inspiration.

Yeah that's a good idea. I tried to extract them based on the registered ones, but it's quite hard to do in 0.3.x. If we update to 0.4.x it would be simpler to extract the registered methods.

Alrighty, can you create an issue and then we will pick it up later :).

TimoGlastra commented 1 year ago

Do you think we should show the supported did methods? Might be nice to check out the unresolver for some inspiration.

Yeah that's a good idea. I tried to extract them based on the registered ones, but it's quite hard to do in 0.3.x. If we update to 0.4.x it would be simpler to extract the registered methods.

Alrighty, can you create an issue and then we will pick it up later :).

https://github.com/animo/siera-desktop/issues/124